RFR: 8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]

Tejesh R tr at openjdk.org
Tue Mar 12 10:22:15 UTC 2024


On Tue, 12 Mar 2024 02:49:25 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 68:

> 66: 
> 67:     private static JSlider slider;
> 68:     private static JFrame frame;

`frame` Can be moved inside `createUI()`.

test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 69:

> 67:     private static JSlider slider;
> 68:     private static JFrame frame;
> 69:     private static JTextField tfLink;

`tfLink` and `btnGC` can be initialized inside `initialize()` and moved there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521204448
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521206245


More information about the client-libs-dev mailing list