RFR: 8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Tue Mar 12 10:54:37 UTC 2024
On Tue, 12 Mar 2024 10:18:06 GMT, Tejesh R <tr at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comment update
>
> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 68:
>
>> 66:
>> 67: private static JSlider slider;
>> 68: private static JFrame frame;
>
> `frame` Can be moved inside `createUI()`.
ok
> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 69:
>
>> 67: private static JSlider slider;
>> 68: private static JFrame frame;
>> 69: private static JTextField tfLink;
>
> `tfLink` and `btnGC` can be initialized inside `initialize()` and moved there.
As I understood, testUI calls the passed method in EDT so I think it's better to init the swing variables there..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521247916
PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521249290
More information about the client-libs-dev
mailing list