RFR: 8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]

Alexey Ivanov aivanov at openjdk.org
Tue Mar 12 12:45:13 UTC 2024


On Tue, 12 Mar 2024 12:37:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 60:
>> 
>>> 58: 
>>> 59:             1. Create a link
>>> 60:             2. Copy path to the link into TextField
>> 
>> I understand the instructions aren't new but I can't comprehend what it's required.
>> 
>> Does it mean a Windows shortcut, `.lnk` file? Seems like it's the case because `getLinkLocation` is called which resolves a shortcut to its original file.
>> 
>> Can the text field be pre-populated with a default? There could be shortcuts on Desktop, there are many shortcuts in the Start menu.
>
> Could you amend the instructions to clarify them?
> 
> Define what is a _link_.

It seems a Windows shortcut is crucial to reproducing the original problem, if it is, the handler for the Start button could show an error message about this fact.

Perhaps, if this link cannot be converted to a file in `MyThread` constructor, `FileNotFoundException` should be propagated and caught in the Start button actionPerformed handler to show an error message and let the tester use another Windows shortcut.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521398715


More information about the client-libs-dev mailing list