RFR: 8327748: Convert javax/swing/JFileChooser/6798062/bug6798062.java applet test to main [v3]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Mar 12 12:50:13 UTC 2024


On Tue, 12 Mar 2024 12:42:53 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Could you amend the instructions to clarify them?
>> 
>> Define what is a _link_.
>
> It seems a Windows shortcut is crucial to reproducing the original problem, if it is, the handler for the Start button could show an error message about this fact.
> 
> Perhaps, if this link cannot be converted to a file in `MyThread` constructor, `FileNotFoundException` should be propagated and caught in the Start button actionPerformed handler to show an error message and let the tester use another Windows shortcut.

SInce this exercise is just to convert applet to main, I tried to keep the instructions same (although I agree it seems ambiguous and I also am not clear what needs to be done) which seems to be ok with the tester since 2009 when the test was written.
I think whatever test change needs to be done should be done in JDK-8146446 as till then this test will not be run..

ELse if you disagree, what you propose to be written in the "instructions"?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18180#discussion_r1521405837


More information about the client-libs-dev mailing list