RFR: 8327857: Remove applet usage from JColorChooser tests Test4222508 [v2]

Phil Race prr at openjdk.org
Tue Mar 12 20:29:19 UTC 2024


On Tue, 12 Mar 2024 00:39:26 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with five additional commits since the last revision:
> 
>  - fix pfjframe builder styling and jtreg manual tag
>  - revert spacing
>  - revert files
>  - restore file
>  - revert file

test/jdk/javax/swing/JColorChooser/Test4222508.java line 32:

> 30:  * @test
> 31:  * @bug 4222508
> 32:  * @library /test/jdk/java/awt/regtesthelpers /test/lib

change this to remove /test/jdk

test/jdk/javax/swing/JColorChooser/Test4222508.java line 44:

> 42:                         "and click on colors again. \n" +
> 43:                         "If the JColorChooser is disabled when the checkbox is unchecked, \n" +
> 44:                         "then pass the test.")

The line breaks here are in random odd places.
It should be more like this
"Click on colors in the JColorChooser.\n" +
"Then uncheck the checkbox and click on colors again.\n" +
"If the JColorChooser is disabled when the checkbox is unchecked, then pass the test.";

You can also  use text blocks if you want

test/jdk/javax/swing/JColorChooser/Test4222508.java line 54:

> 52: 
> 53:     public static JFrame test() {
> 54:         JFrame frame = new JFrame();

give the frame a meaningful title that is not identical to the one to the PassFailJFrame.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1522066024
PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1522068889
PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1522070278


More information about the client-libs-dev mailing list