RFR: 8327857: Remove applet usage from JColorChooser tests Test4222508 [v2]

Tejesh R tr at openjdk.org
Wed Mar 13 05:06:14 UTC 2024


On Tue, 12 Mar 2024 00:39:26 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with five additional commits since the last revision:
> 
>  - fix pfjframe builder styling and jtreg manual tag
>  - revert spacing
>  - revert files
>  - restore file
>  - revert file

test/jdk/javax/swing/JColorChooser/Test4222508.java line 37:

> 35:  * @run main/manual Test4222508
> 36:  */
> 37: public final class Test4222508 {

line space here.

test/jdk/javax/swing/JColorChooser/Test4222508.java line 61:

> 59: 
> 60:         frame.getContentPane().add(chooser, BorderLayout.SOUTH);
> 61:         frame.getContentPane().add(checkbox, BorderLayout.NORTH);

U can directly add to frame, without getting the ContentPane.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1522521299
PR Review Comment: https://git.openjdk.org/jdk/pull/18209#discussion_r1522521879


More information about the client-libs-dev mailing list