RFR: 8327753: Convert javax/swing/JOptionPane/8024926/bug8024926.java applet to main [v2]
Phil Race
prr at openjdk.org
Wed Mar 13 05:46:15 UTC 2024
On Wed, 13 Mar 2024 05:21:32 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove redundant dir
test/jdk/javax/swing/JOptionPane/bug8024926.java line 46:
> 44: Verify that high resolution system icons are used
> 45: in JOptionPane on HiDPI displays.
> 46: 1) Run the test on Retina display or enable the Quartz Debug
Quartz debug ? How ? And we don't even use Quartz.
The pass criteria is completely subjective.
So this test looks like it needs to be better.
If you can't figure out a better test for this in less than a day just delete this useless thing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18232#discussion_r1522556572
More information about the client-libs-dev
mailing list