RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]
Alexey Ivanov
aivanov at openjdk.org
Fri Mar 15 10:45:38 UTC 2024
On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>
> Added summary
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 48:
> 46: * @run main/manual/othervm -Djava.security.manager=allow SecurityDialogTest
> 47: */
> 48: public class SecurityDialogTest extends Frame {
Suggestion:
public class SecurityDialogTest {
It does not need to extend `Frame`.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18299#pullrequestreview-1938621163
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1526078681
More information about the client-libs-dev
mailing list