RFR: JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs [v2]

[Alexey Ivanov]

On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the test with  PassFailJFrame with information panel, earlier this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added summary

> > INSTRUCTIONS can be moved inside main.
>
> No. Well, it can but what's the point?

IDE never suggests converting *constants* to local variables. It is because constants can be inlined by Java compiler.

Static or instance fields as well as local variables are usually kept. Converting a field to local variable reduces the size of the object.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18299#issuecomment-1999395558