RFR: 8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v4]

Tejesh R tr at openjdk.org
Wed Mar 20 06:41:20 UTC 2024


On Fri, 15 Mar 2024 07:38:56 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   jtreg manual tag update

test/jdk/javax/swing/JToggleButton/bug4128979.java line 32:

> 30:  * @summary Tests that background changes correctly in WinLF for JToggleButton when pressed
> 31:  * @run main/manual bug4128979
> 32:  */

Move it after imports.

test/jdk/javax/swing/JToggleButton/bug4128979.java line 55:

> 53: 
> 54: public class bug4128979 {
> 55:     private static JFrame frame;

`frame `can be moved inside `createAndShowUI()`.

test/jdk/javax/swing/JToggleButton/bug4128979.java line 65:

> 63: 
> 64:             If the background color does not change correctly for at least one button,
> 65:             the test fails. """;

Getting a white space after `fails.`, can you check once.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1531560138
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1531563247
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1531563877


More information about the client-libs-dev mailing list