RFR: 8327980: Convert javax/swing/JToggleButton/4128979/bug4128979.java applet test to main [v4]

Abhishek Kumar abhiscxk at openjdk.org
Wed Mar 20 08:30:36 UTC 2024


On Wed, 20 Mar 2024 06:32:26 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   jtreg manual tag update
>
> test/jdk/javax/swing/JToggleButton/bug4128979.java line 32:
> 
>> 30:  * @summary Tests that background changes correctly in WinLF for JToggleButton when pressed
>> 31:  * @run main/manual bug4128979
>> 32:  */
> 
> Move it after imports.

Updated but placing of imports is still confusing.

> test/jdk/javax/swing/JToggleButton/bug4128979.java line 55:
> 
>> 53: 
>> 54: public class bug4128979 {
>> 55:     private static JFrame frame;
> 
> `frame `can be moved inside `createAndShowUI()`.

Updated.

> test/jdk/javax/swing/JToggleButton/bug4128979.java line 65:
> 
>> 63: 
>> 64:             If the background color does not change correctly for at least one button,
>> 65:             the test fails. """;
> 
> Getting a white space after `fails.`, can you check once.

Not a problem though since it is part of instruction. Anyways removed extra space.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1531667599
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1531669136
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1531670435


More information about the client-libs-dev mailing list