RFR: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Thu Mar 21 04:54:20 UTC 2024
On Wed, 20 Mar 2024 22:16:36 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>
> Add new line
Marked as reviewed by psadhukhan (Reviewer).
test/jdk/javax/swing/JCheckBox/bug8032667.java line 87:
> 85: }
> 86: };
> 87: frame.getContentPane().add(canvas, BorderLayout.CENTER);
It seems getContentPane is not needed and is obsoleted since jdk1.5...See this [comment](https://github.com/openjdk/jdk/pull/18390#discussion_r1533017080)
-------------
PR Review: https://git.openjdk.org/jdk/pull/18403#pullrequestreview-1950755132
PR Review Comment: https://git.openjdk.org/jdk/pull/18403#discussion_r1533245336
More information about the client-libs-dev
mailing list