RFR: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main [v2]

Alexey Ivanov aivanov at openjdk.org
Thu Mar 21 11:56:20 UTC 2024


On Wed, 20 Mar 2024 22:16:36 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add new line

test/jdk/javax/swing/JCheckBox/bug8032667.java line 78:

> 76:         final Image image1 = getImage(getCheckBox("Deselected", false));
> 77:         final Image image2 = getImage(getCheckBox("Selected", true));
> 78:         Canvas canvas = new Canvas() {

I recommend using `JPanel` instead of `Canvas`. The former is a Swing lightweight component, whereas the latter is an AWT heavyweight component. It's still better not to mix them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18403#discussion_r1533748612


More information about the client-libs-dev mailing list