RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test to main [v4]
Abhishek Kumar
abhiscxk at openjdk.org
Thu Mar 21 07:44:22 UTC 2024
On Mon, 18 Mar 2024 17:40:03 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> Convert java/awt/im/JTextFieldTest.java applet test to main using PassFailJFrame.
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove reundant window constant
Marked as reviewed by abhiscxk (Committer).
test/jdk/java/awt/im/JTextFieldTest.java line 32:
> 30: * work correctly with IM when there is an uneditable peered
> 31: * TextField/TextArea in the same parent Frame
> 32: * @run main JTextFieldTest
should be main/manual ?
test/jdk/java/awt/im/JTextFieldTest.java line 42:
> 40:
> 41: public class JTextFieldTest {
> 42: private static JFrame frame;
can be moved to local scope in `createAndShowGUI` method.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18247#pullrequestreview-1950991412
PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1533367255
PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1533367750
More information about the client-libs-dev
mailing list