RFR: 8328005: Convert java/awt/im/JTextFieldTest.java applet test to main [v4]

Damon Nguyen dnguyen at openjdk.org
Thu Mar 21 16:11:35 UTC 2024


On Thu, 21 Mar 2024 07:41:15 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove reundant window constant
>
> test/jdk/java/awt/im/JTextFieldTest.java line 32:
> 
>> 30:  *           work correctly with IM when there is an uneditable peered
>> 31:  *           TextField/TextArea in the same parent Frame
>> 32:  * @run main JTextFieldTest
> 
> should be main/manual ?

Fixed.

> test/jdk/java/awt/im/JTextFieldTest.java line 42:
> 
>> 40: 
>> 41: public class JTextFieldTest {
>> 42:     private static JFrame frame;
> 
> can be moved to local scope in `createAndShowGUI` method.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1534215303
PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1534215460


More information about the client-libs-dev mailing list