RFR: 8328402: Implement pausing functionality for the PassFailJFrame [v3]

Alexey Ivanov aivanov at openjdk.org
Thu Mar 21 12:00:26 UTC 2024


On Thu, 21 Mar 2024 11:51:43 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>>> we need to add next to Pass/Fail a "Pause Timer" button, that
>> (a) stops the count down
>> (b) changes the Pause Timer to "Resume Timer"
>> ~~(c) disables Pass/Fail until the timer is resumed~~
>> the test will not have to pause or be aware - only the PassFailJFrame machinery.
>> ~~So the tester can do anything they want except exit the test in the paused mode.~~
>> 
>> This PR implements everything except the (c).
>> I see nothing wrong with completing the test from the paused state, and it does not add an extra click.  
>> 
>> 
>> Example screenshots:
>> 
>> ![image](https://github.com/openjdk/jdk/assets/77687766/65d34bf8-1e46-4e68-b39e-a77f257ec3c0)
>> ![image](https://github.com/openjdk/jdk/assets/77687766/3a43e059-2d48-46f3-9d1b-c2ab84fcce37)
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   TimeoutHandlerPanel.PAUSE_BUTTON_LABEL -> PAUSE_BUTTON_LABEL

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18368#pullrequestreview-1951984347


More information about the client-libs-dev mailing list