Integrated: 8328402: Implement pausing functionality for the PassFailJFrame

Alexander Zvegintsev azvegint at openjdk.org
Thu Mar 21 15:34:26 UTC 2024


On Tue, 19 Mar 2024 01:14:29 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> we need to add next to Pass/Fail a "Pause Timer" button, that
> (a) stops the count down
> (b) changes the Pause Timer to "Resume Timer"
> ~~(c) disables Pass/Fail until the timer is resumed~~
> the test will not have to pause or be aware - only the PassFailJFrame machinery.
> ~~So the tester can do anything they want except exit the test in the paused mode.~~
> 
> This PR implements everything except the (c).
> I see nothing wrong with completing the test from the paused state, and it does not add an extra click.  
> 
> 
> Example screenshots:
> 
> ![image](https://github.com/openjdk/jdk/assets/77687766/65d34bf8-1e46-4e68-b39e-a77f257ec3c0)
> ![image](https://github.com/openjdk/jdk/assets/77687766/3a43e059-2d48-46f3-9d1b-c2ab84fcce37)

This pull request has now been integrated.

Changeset: 581b1e29
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/581b1e29aebd425bade14d2ee46704a16187df5b
Stats:     47 lines in 1 file changed: 35 ins; 2 del; 10 mod

8328402: Implement pausing functionality for the PassFailJFrame

Reviewed-by: aivanov, prr

-------------

PR: https://git.openjdk.org/jdk/pull/18368


More information about the client-libs-dev mailing list