RFR: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main [v2]
Damon Nguyen
dnguyen at openjdk.org
Thu Mar 21 16:08:49 UTC 2024
On Thu, 21 Mar 2024 11:52:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add new line
>
> test/jdk/javax/swing/JCheckBox/bug8032667.java line 78:
>
>> 76: final Image image1 = getImage(getCheckBox("Deselected", false));
>> 77: final Image image2 = getImage(getCheckBox("Selected", true));
>> 78: Canvas canvas = new Canvas() {
>
> I recommend using `JPanel` instead of `Canvas`. The former is a Swing lightweight component, whereas the latter is an AWT heavyweight component. It's still better not to mix them.
Replaced `Canvas` with `JPanel`. Thanks
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18403#discussion_r1534211977
More information about the client-libs-dev
mailing list