RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main [v2]

[Alexander Zuev]

On Thu, 21 Mar 2024 20:22:18 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 59:
>> 
>>> 57:         frame.add(textScrollPane, BorderLayout.CENTER);
>>> 58: 
>>> 59:         fd = new FileDialog(new Frame(), "Open");
>> 
>> is there any need to mix Swing and AWT components in the test? I guess you can use the JFrame already created
>
> Actually you don't need the textOutput, with recent changes you can add `.logArea()` to the PassFailJFrame builder
> 
> https://github.com/openjdk/jdk/blob/master/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L1200
> 
> and just use `PassFailJFrame.log()` wherever you need it.
> 
> So this method can be changed to return the a `JButton`, and use it with `splitUIBottom`/`splitUIRight` instead of testUI

Ok, using the PassFailJFrame logger.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1535060230