RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main [v2]

[Alexander Zuev]

On Thu, 21 Mar 2024 16:16:55 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding library and build clauses
>
> test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 60:
> 
>> 58: 
>> 59:         fd = new FileDialog(new Frame(), "Open");
>> 60:         fd.setDirectory(APPLICATIONS_FOLDER);
> 
> guess APPLICATION_FOLDER can be made local

With Alexander's suggestion all variables could be made local. Fixing that.

> test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 91:
> 
>> 89:                 .rows((int) instructions.lines().count() + 1)
>> 90:                 .columns(40)
>> 91:                 .testUI(FileDialogForPackages::initialize)
> 
> It seems the filedialog is obscuring the instruction and test window...I guess it will be good if you can use 
> position(PassFailJFrame.Position.TOP_LEFT_CORNER)

Unfortunately i can not reposition the test instructions dialog and i got rid of the test window so newly created filedialog will block the instructions. Not sure i can find a reliable way to avoid that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1535059877
PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1535061055