RFR: 8328670: Automate and open source few closed manual applet test [v2]

[Tejesh R]

On Thu, 21 Mar 2024 17:36:40 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few manual closed applet test converted to automated and open sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove getContentPane usage

test/jdk/javax/swing/JInternalFrame/Ctrli.java line 75:

> 73:             robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
> 74:             robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
> 75:             robot.waitForIdle();

Only `robot.waitForIdle();` is sufficient ? Delay isn't required?

test/jdk/javax/swing/JInternalFrame/Ctrli.java line 86:

> 84:             if (!iPressed) {
> 85:                 throw new RuntimeException("Test failed: CTRL+I not pressed.");
> 86:             }

Console print mentioning "Test Passed" would bring some clarity about the test status I guess.

test/jdk/javax/swing/JInternalFrame/Ctrli.java line 129:

> 127:         frame.setSize(200, 200);
> 128:         frame.setLocationRelativeTo(null);
> 129:         frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

`frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);` is not required I guess.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535143315
PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535145084
PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535145669