RFR: 8328670: Automate and open source few closed manual applet test [v2]

[Abhishek Kumar]

On Fri, 22 Mar 2024 07:17:00 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove getContentPane usage
>
> test/jdk/javax/swing/JInternalFrame/Ctrli.java line 75:
> 
>> 73:             robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
>> 74:             robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
>> 75:             robot.waitForIdle();
> 
> Only `robot.waitForIdle();` is sufficient ? Delay isn't required?

No.

> test/jdk/javax/swing/JInternalFrame/Ctrli.java line 86:
> 
>> 84:             if (!iPressed) {
>> 85:                 throw new RuntimeException("Test failed: CTRL+I not pressed.");
>> 86:             }
> 
> Console print mentioning "Test Passed" would bring some clarity about the test status I guess.

Don't think so. Test is all about CTRL+I pressed, if it fails that means event is not triggered.

> test/jdk/javax/swing/JInternalFrame/Ctrli.java line 129:
> 
>> 127:         frame.setSize(200, 200);
>> 128:         frame.setLocationRelativeTo(null);
>> 129:         frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
> 
> `frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);` is not required I guess.

Since it is an automatic test, I guess it is required.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535251059
PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535252345
PR Review Comment: https://git.openjdk.org/jdk/pull/18428#discussion_r1535253676