RFR: 8316324: Opensource five miscellaneous Swing tests

Phil Race prr at openjdk.org
Sun Mar 24 00:03:21 UTC 2024


On Fri, 22 Mar 2024 08:54:07 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Clean up and opensource five tests.
>
> test/jdk/javax/swing/InputVerifier/bug4774166.java line 229:
> 
>> 227:     public void cleanupGUI() {
>> 228:         if (testframe != null) {
>> 229:             testframe.setVisible(false);
> 
> `testframe.setVisible(false);` is required here? Any advantage for setting the visibility to false ? anyhow its been disposed.....

Not harmful, but not needed either.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1536710591


More information about the client-libs-dev mailing list