RFR: 8316324: Opensource five miscellaneous Swing tests

Alexander Zuev kizune at openjdk.org
Mon Mar 25 16:18:31 UTC 2024


On Sun, 24 Mar 2024 00:00:25 GMT, Phil Race <prr at openjdk.org> wrote:

>> test/jdk/javax/swing/InputVerifier/bug4774166.java line 229:
>> 
>>> 227:     public void cleanupGUI() {
>>> 228:         if (testframe != null) {
>>> 229:             testframe.setVisible(false);
>> 
>> `testframe.setVisible(false);` is required here? Any advantage for setting the visibility to false ? anyhow its been disposed.....
>
> Not harmful, but not needed either.

Ok, removing them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1537856832


More information about the client-libs-dev mailing list