RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]

Damon Nguyen dnguyen at openjdk.org
Fri Mar 29 16:43:36 UTC 2024


On Wed, 27 Mar 2024 18:20:59 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are converted to main and open-sourced:
>> 
>> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using PassFailJFrame.
>> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
>> - /java/awt/Frame/MinimizeUndecoratedTest.java - Automated
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing

test/jdk/java/awt/Frame/MaximizeUndecoratedTest.java line 127:

> 125:         } catch (IOException e) {
> 126:             e.printStackTrace();
> 127:         }

Is it best to just print the stack trace when a screenshot fails? Or is it better to throw a new runtime error?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18523#discussion_r1544683152


More information about the client-libs-dev mailing list