RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]

Harshitha Onkar honkar at openjdk.org
Fri Mar 29 17:29:09 UTC 2024


On Fri, 29 Mar 2024 16:41:13 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   spacing
>
> test/jdk/java/awt/Frame/MaximizeUndecoratedTest.java line 127:
> 
>> 125:         } catch (IOException e) {
>> 126:             e.printStackTrace();
>> 127:         }
> 
> Is it best to just print the stack trace when a screenshot fails? Or is it better to throw a new runtime error?

It is better to re-throw it as RuntimeException. Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18523#discussion_r1544715093


More information about the client-libs-dev mailing list