RFR: 8332416: Add more font selection options to Font2DTest [v3]

Harshitha Onkar honkar at openjdk.org
Thu May 23 20:44:01 UTC 2024


On Thu, 23 May 2024 19:51:10 GMT, Phil Race <prr at openjdk.org> wrote:

>> src/demo/share/jfc/Font2DTest/Font2DTest.java line 1440:
>> 
>>> 1438:                 f.addWindowListener( new WindowAdapter() {
>>> 1439:                     public void windowOpening( WindowEvent e ) { f2dt.repaint(); }
>>> 1440:                     public void windowClosing( WindowEvent e ) { System.exit(0); }
>> 
>> @prrace Minor Spacing issue. I see this pattern in the original code as well, could be a quick find+replace all fix for opening and closing brace. But then again it would also create a lot of git diff footprint along with the fix.
>> 
>> Suggestion:
>> 
>>                 f.addWindowListener( new WindowAdapter() {
>>                     public void windowOpening(WindowEvent e) { f2dt.repaint(); }
>>                     public void windowClosing(WindowEvent e) { System.exit(0); }
>
> There's a LOT of such things, that my itchy fingers wanted to fix, but  I deliberately resisted temptation and don't see any reason to pick on a few random infractions to fix.

Agreed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19273#discussion_r1612278346


More information about the client-libs-dev mailing list