RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v13]

Alexander Scherbatiy alexsch at openjdk.org
Mon May 27 17:02:36 UTC 2024


On Mon, 27 May 2024 07:41:37 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Alexander Scherbatiy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move jtreg tags below the imports in the tests
>
> test/jdk/javax/print/attribute/OutputBinAttributePrintDialogTest.java line 187:
> 
>> 185:             return new OutputBin[0];
>> 186:         }
>> 187: 
> 
> I guess before getting supported Attribute Values, we need to ensure category is supported by calling `service.isAttributeCategorySupported(OutputBin.class)`
> in my opinion

The test updated to check if the OutputBin category is supported.

> test/jdk/javax/print/attribute/OutputBinAttributeTest.java line 165:
> 
>> 163:         if (service == null) {
>> 164:             return supportedOutputBins;
>> 165:         }
> 
> same here for check of `isAttributeCategorySupported()`

The test is updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1616269362
PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1616269594


More information about the client-libs-dev mailing list