RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v13]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Tue May 28 07:57:07 UTC 2024
On Mon, 27 May 2024 16:59:08 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:
>> test/jdk/javax/print/attribute/OutputBinAttributePrintDialogTest.java line 187:
>>
>>> 185: return new OutputBin[0];
>>> 186: }
>>> 187:
>>
>> I guess before getting supported Attribute Values, we need to ensure category is supported by calling `service.isAttributeCategorySupported(OutputBin.class)`
>> in my opinion
>
> The test updated to check if the OutputBin category is supported.
I think if `isATtributeCategorySupported `returns false, we should not return OutputBin[0] as that will cause the test to pass with message "SKip the test as number of supported outputbins is less than 2", which is misleading, in my opinion
It should instead message "Skipping the test as OutputBin category is not supported for this printer"
Also, `getPrintService` returning null also return the above outputbin message..It should rather return "No print service found"
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1616765093
More information about the client-libs-dev
mailing list