RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v13]

Alexander Scherbatiy alexsch at openjdk.org
Tue May 28 17:01:04 UTC 2024


On Tue, 28 May 2024 07:52:54 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The test updated to check if the OutputBin category is supported.
>
> I think if `isATtributeCategorySupported `returns false, we should not return OutputBin[0] as that will cause the test to pass with message "SKip the test as number of supported outputbins is less than 2", which is misleading, in my opinion
> It should instead message "Skipping the test as OutputBin category is not supported for this printer"
> 
> Also, `getPrintService` returning null also return the above outputbin message..It should rather return "No print service found"

The test is updated to print messages if `getPrintService()` returns null or the OutputBin category is not supported and check the case that when the OutputBin category is supported there should be supported output bins.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1617631457


More information about the client-libs-dev mailing list