RFR: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized
Prasanta Sadhukhan
psadhukhan at openjdk.org
Thu May 30 13:04:36 UTC 2024
Issue is in macosx, when a JMenu or JPopupmenu is opened and then window is resized from the lower right corner, then the Menu / JPopupmenu stays open unlike in native osx apps like Notes, Mail etc..
This is because when LMouseButton is pressed on non-client area, the window should get a UngrabEvent for it to close/cancel the popupmenu (as is done in [windows](https://github.com/openjdk/jdk/blob/f608918df3f887277845db383cf07b0863bba615/src/java.desktop/windows/native/libawt/windows/awt_Frame.cpp#L618-L620)) but it was seen that the mac AWTWindow code only recognizes the title-bar as the non-client area so [notifyNCMouseDown](https://github.com/openjdk/jdk/blob/f608918df3f887277845db383cf07b0863bba615/src/java.desktop/macosx/classes/sun/lwawt/LWWindowPeer.java#L797-L804) is not called.
Fix is made to recognize the edges of the window as non-client area
-------------
Commit messages:
- Copyright
- Copyright
- Copyright
- jcheck
- jcheck
- 8325435: [macos] Menu or JPopupMenu not closed when main window is resized
Changes: https://git.openjdk.org/jdk/pull/19474/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19474&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8325435
Stats: 110 lines in 2 files changed: 109 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/19474.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19474/head:pull/19474
PR: https://git.openjdk.org/jdk/pull/19474
More information about the client-libs-dev
mailing list