RFR: 8314070: javax.print: Support IPP output-bin attribute extension [v16]
Alexander Scherbatiy
alexsch at openjdk.org
Thu May 30 18:22:11 UTC 2024
On Thu, 30 May 2024 07:27:13 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with five additional commits since the last revision:
>>
>> - Update imports order in CheckSupportedOutputBinsTest
>> - Use only bug id number in bug tag in tests
>> - Fix imports order
>> - Fix formatting in the for loop
>> - Update PrintService.isAttributeValueSupported() function for OutputBin constants
>
> test/jdk/javax/print/attribute/CheckSupportedOutputBinsTest.java line 36:
>
>> 34: * @test
>> 35: * @bug 8314070
>> 36: * @key printer
>
> DO you want to run this on all platforms? Other tests are for linux and mac only!! but guess it's not a problem..
Yes, this test is intended to run on all platforms. On Windows it just checks that there are no unexpected exceptions if `OutputBin` category is passed to `PrintService` methods.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1621240124
More information about the client-libs-dev
mailing list