RFR: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java [v5]

Daniel Gredler duke at openjdk.org
Thu Nov 7 00:22:05 UTC 2024


On Wed, 6 Nov 2024 19:14:19 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Daniel Gredler has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use constants in switch, update problem list
>
> test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 289:
> 
>> 287:             Graphics2D g2d = (Graphics2D)g;
>> 288:             g2d.translate(pf.getImageableX(),  pf.getImageableY());
>> 289:             g.drawString(page+" "+orient(pf),50,20);
> 
> Suggestion:
> 
>             g2d.translate(pf.getImageableX(), pf.getImageableY());
>             g.drawString(page + " " + orient(pf), 50, 20);

Thanks! I've tried to address all of the whitespace quirks, let me know if there is anything else that catches your eye.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1831885375


More information about the client-libs-dev mailing list