RFR: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java [v5]

Alexey Ivanov aivanov at openjdk.org
Thu Nov 7 16:31:47 UTC 2024


On Thu, 7 Nov 2024 00:19:03 GMT, Daniel Gredler <duke at openjdk.org> wrote:

>> test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 289:
>> 
>>> 287:             Graphics2D g2d = (Graphics2D)g;
>>> 288:             g2d.translate(pf.getImageableX(),  pf.getImageableY());
>>> 289:             g.drawString(page+" "+orient(pf),50,20);
>> 
>> Suggestion:
>> 
>>             g2d.translate(pf.getImageableX(), pf.getImageableY());
>>             g.drawString(page + " " + orient(pf), 50, 20);
>
> Thanks! I've tried to address all of the whitespace quirks, let me know if there is anything else that catches your eye.

I was inclined to leave untouched lines as is, there are many formatting inconsistencies in the test code.

If we fix them all, it'll create noise where it'd be hard to see what's really changed.  
I wouldn't mind if the formatting is updated under a separate bug id.

There's no need to revert the updated lines.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1832988262


More information about the client-libs-dev mailing list