RFR: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java [v5]

Daniel Gredler duke at openjdk.org
Thu Nov 7 17:01:53 UTC 2024


On Thu, 7 Nov 2024 16:28:54 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Thanks! I've tried to address all of the whitespace quirks, let me know if there is anything else that catches your eye.
>
> I was inclined to leave untouched lines as is, there are many formatting inconsistencies in the test code.
> 
> If we fix them all, it'll create noise where it'd be hard to see what's really changed.  
> I wouldn't mind if the formatting is updated under a separate bug id.
> 
> There's no need to revert the updated lines.

Understood. I don't have access to create new issues, so one of the other team members would need to do that. Can you mark the PR reviewed, if you're OK with it as is? This last whitespace feedback came through after the bug was marked as ready for integration, and it looks like the fix then triggered a requirement for re-reviews in the system.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1833038231


More information about the client-libs-dev mailing list