RFR: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java [v6]

[Alexey Ivanov]

On Thu, 7 Nov 2024 00:22:05 GMT, Daniel Gredler <duke at openjdk.org> wrote:

>> There are multiple issue with this test case
>> 1) Parser error due to yesno in @run main/manual=yesno
>> 2) User can only compare the UI rendering and compare with the print out. User can't mark the test as pass or fail due to pass or fail buttons are missing.
>> 3) When the test is executed using jtreg after user click on the print button on the print dialog the whole test UIs ( frames) gets dispose and user cannot compare the printout with the UI. But this works as expected in test is running individually using java PrintTextTest
>
> Daniel Gredler has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Whitespace fixes

I see you've handled nearly all formatting issues, therefore you should resolve the remaining ones too.

test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 138:

> 136:         font = new Font(Font.DIALOG, Font.PLAIN, 18);
> 137:         scaleTx = AffineTransform.getScaleInstance(-1.25, 1.25);
> 138:         scaleTx.translate(-preferredSize/1.25, 0);

Suggestion:

        scaleTx.translate(-preferredSize / 1.25, 0);

test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 147:

> 145:         font = new Font(Font.DIALOG, Font.PLAIN, 18);
> 146:         scaleTx = AffineTransform.getScaleInstance(1.25, -1.25);
> 147:         scaleTx.translate(0, -preferredSize/1.25);

Suggestion:

        scaleTx.translate(0, -preferredSize / 1.25);

test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 383:

> 381:             int ng = gv.getNumGlyphs();
> 382:             adv = gv.getGlyphPosition(ng);
> 383:             for (int i=0; i<ng; i++) {

Suggestion:

            for (int i = 0; i < ng; i++) {

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21716#pullrequestreview-2421617309
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1833044104
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1833045387
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1833049870