RFR: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java [v6]

[Daniel Gredler]

On Thu, 7 Nov 2024 17:03:17 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Daniel Gredler has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Whitespace fixes
>
> test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 138:
> 
>> 136:         font = new Font(Font.DIALOG, Font.PLAIN, 18);
>> 137:         scaleTx = AffineTransform.getScaleInstance(-1.25, 1.25);
>> 138:         scaleTx.translate(-preferredSize/1.25, 0);
> 
> Suggestion:
> 
>         scaleTx.translate(-preferredSize / 1.25, 0);

Updated.

> test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 147:
> 
>> 145:         font = new Font(Font.DIALOG, Font.PLAIN, 18);
>> 146:         scaleTx = AffineTransform.getScaleInstance(1.25, -1.25);
>> 147:         scaleTx.translate(0, -preferredSize/1.25);
> 
> Suggestion:
> 
>         scaleTx.translate(0, -preferredSize / 1.25);

Updated.

> test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 219:
> 
>> 217:         PassFailJFrame.builder()
>> 218:             .title("PrintTextTest")
>> 219:             .instructions(INSTRUCTIONS)
> 
> Suggestion:
> 
>             .instructions(INSTRUCTIONS)
>             .testTimeOut(10)
> 
> I tried running the test and actually comparing the images… the timeout of 5 minutes is too short, we should increase the timeout to 10 or even 15 minutes.

Updated.

> test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 383:
> 
>> 381:             int ng = gv.getNumGlyphs();
>> 382:             adv = gv.getGlyphPosition(ng);
>> 383:             for (int i=0; i<ng; i++) {
> 
> Suggestion:
> 
>             for (int i = 0; i < ng; i++) {

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1833120253
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1833120417
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1833120921
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1833120553