RFR: 8344059: Remove doPrivileged calls from windows platform sources in the java.desktop module [v3]

[Phil Race]

On Thu, 14 Nov 2024 10:52:44 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Since JEP 486 : Permanently Disable the Security Manager
>> [https://bugs.openjdk.org/browse/JDK-8338625] is now integrated, calls to java.security.AccessController.doPrivileged are obsolete and can be removed. 
>> 
>> This PR takes care of the windows-platform files in the java.desktop module to have them removed.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove GetPropertyAction

src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java line 591:

> 589:                 }
> 590:             };
> 591:             /* The thread must be a member of a thread group

line 579 above (which does not show in the diff still has SuppressWarnings("removal")
I'm not sure why it is still needed. Oversight ?

src/java.desktop/windows/classes/sun/awt/windows/WMenuItemPeer.java line 147:

> 145: 
> 146:     static {
> 147:         try {

I guess something else (logging?) needs that SuppressWarning you left on the class ??

src/java.desktop/windows/classes/sun/java2d/d3d/D3DScreenUpdateManager.java line 92:

> 90:     private HashMap<D3DWindowSurfaceData, GDIWindowSurfaceData> gdiSurfaces;
> 91: 
> 92:     @SuppressWarnings("removal")

still needed ?

src/java.desktop/windows/classes/sun/java2d/d3d/D3DScreenUpdateManager.java line 346:

> 344:     private synchronized void startUpdateThread() {
> 345:         if (screenUpdater == null) {
> 346:             String name = "D3D Screen Updater";

@SuppressWarnings("removal") still needed ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1843013161
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1843015024
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1843016021
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1843016839