RFR: 8344059: Remove doPrivileged calls from windows platform sources in the java.desktop module [v3]

[Prasanta Sadhukhan]

On Thu, 14 Nov 2024 23:37:00 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove GetPropertyAction
>
> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java line 591:
> 
>> 589:                 }
>> 590:             };
>> 591:             /* The thread must be a member of a thread group
> 
> line 579 above (which does not show in the diff still has SuppressWarnings("removal")
> I'm not sure why it is still needed. Oversight ?

missed earlier..removed..

> src/java.desktop/windows/classes/sun/awt/windows/WMenuItemPeer.java line 147:
> 
>> 145: 
>> 146:     static {
>> 147:         try {
> 
> I guess something else (logging?) needs that SuppressWarning you left on the class ??

no, removed..

> src/java.desktop/windows/classes/sun/java2d/d3d/D3DScreenUpdateManager.java line 92:
> 
>> 90:     private HashMap<D3DWindowSurfaceData, GDIWindowSurfaceData> gdiSurfaces;
>> 91: 
>> 92:     @SuppressWarnings("removal")
> 
> still needed ?

removed..

> src/java.desktop/windows/classes/sun/java2d/d3d/D3DScreenUpdateManager.java line 346:
> 
>> 344:     private synchronized void startUpdateThread() {
>> 345:         if (screenUpdater == null) {
>> 346:             String name = "D3D Screen Updater";
> 
> @SuppressWarnings("removal") still needed ?

removed..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1843140113
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1843140191
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1843140236
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1843140300