RFR: 8344059: Remove doPrivileged calls from windows platform sources in the java.desktop module [v7]
Alexey Ivanov
aivanov at openjdk.org
Mon Nov 18 20:07:50 UTC 2024
On Mon, 18 Nov 2024 20:02:07 GMT, Phil Race <prr at openjdk.org> wrote:
>> src/java.desktop/windows/classes/sun/awt/windows/WPathGraphics.java line 102:
>>
>>> 100:
>>> 101: if (textLayoutStr != null) {
>>> 102: useGDITextLayout = Boolean.getBoolean(textLayoutStr);
>>
>> This line seems wrong: `textLayoutStr` is a value of the property, and we now read a new property with the value of the `sun.java2d.print.enableGDITextLayout` property.
>>
>> Is it what's intended? The following line—`textLayoutStr.equalsIgnoreCase("prefer")`—assumes it's not the intended usage.
>
> If there's an existing problem, let's examine it under a separate bug. This change is about equivalence
Yes, it's an existing problem, I'm just bringing it up.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1847191810
More information about the client-libs-dev
mailing list