RFR: 8344059: Remove doPrivileged calls from windows platform sources in the java.desktop module [v7]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Nov 19 03:16:52 UTC 2024


On Mon, 18 Nov 2024 19:55:58 GMT, Phil Race <prr at openjdk.org> wrote:

>> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/XPStyle.java line 134:
>> 
>>> 132:             }
>>> 133:             if (themeActive.booleanValue()) {
>>> 134:                 String propertyAction = System.getProperty("swing.noxp");
>> 
>> The variable name is now confusing… it's not an action anymore. Alternative, `getProperty` can be inlined in the `if` statement.
>
> A goal here is to MINIMISE optional refactoring, this is borderline. I'll leave it up to Prasanta.

SInce there is no more change to be done, I will skip this..It can be handled separately in a cleanup later on..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1847578343


More information about the client-libs-dev mailing list