RFR: 8148334: The regression case: java/awt/print/PrinterJob/PrintTextTest.java failed as the printed pages do not match the shown pages [v2]

Daniel Gredler duke at openjdk.org
Mon Nov 18 22:35:42 UTC 2024


On Mon, 18 Nov 2024 19:57:08 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> @honkar-jdk Interesting, it looks like this fixes Linux then, but not Windows (although the code change is in the shared `PathGraphics` class). Any idea what Mac looks like on page 8 right now? It looks to me like the Windows screenshot is showing two separate bugs (start position, and then individual glyph advances) -- but that's just a guess.
>> 
>> We may need to create a separate bug in the bug tracker just for Linux page 8 and this PR, since it looks like there are still other issues to be fixed in JDK-8148334.
>> 
>> Linux screenshot:
>> 
>> ![linux](https://github.com/user-attachments/assets/61187b29-ce74-497d-a5be-bc6ba1d40e41)
>
> @gredler MacOS looks different. There seems to be some clipping issues or bound issues when printing. In fact, I don't even see the `GlyphVector` characters being printed. Could not be printed at all or moved somewhere off the page. Really odd. The changes made here don't seem to affect this though since it seems to be an issue both before & after.
> 
> ![image](https://github.com/user-attachments/assets/f62671e2-85ef-482a-be9c-aa077982ed5a)

@DamonGuy Brilliant, thanks for the check. This feels like it might be drawing offscreen because of incorrectly-combined transforms, like what was fixed in PR #20993 (but this would be somewhere in the Mac-specific code).

@honkar-jdk I was able to dig up an old Windows laptop, and have confirmed that the page 8 issue on Windows is caused by two regressions introduced over the past decade but not caught because this is a manual test, not an automated test... I'm going to see if I can't get this test passing on both Linux and Windows. Keep an eye out for additional commits to this PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21980#issuecomment-2484272837


More information about the client-libs-dev mailing list