RFR: 8148334: The regression case: java/awt/print/PrinterJob/PrintTextTest.java failed as the printed pages do not match the shown pages [v2]

Harshitha Onkar honkar at openjdk.org
Tue Nov 19 01:52:47 UTC 2024


On Mon, 18 Nov 2024 22:33:11 GMT, Daniel Gredler <duke at openjdk.org> wrote:

>> @gredler MacOS looks different. There seems to be some clipping issues or bound issues when printing. In fact, I don't even see the `GlyphVector` characters being printed. Could not be printed at all or moved somewhere off the page. Really odd. The changes made here don't seem to affect this though since it seems to be an issue both before & after.
>> 
>> ![image](https://github.com/user-attachments/assets/f62671e2-85ef-482a-be9c-aa077982ed5a)
>
> @DamonGuy Brilliant, thanks for the check. This feels like it might be drawing offscreen because of incorrectly-combined transforms, like what was fixed in PR #20993 (but this would be somewhere in the Mac-specific code).
> 
> @honkar-jdk I was able to dig up an old Windows laptop, and have confirmed that the page 8 issue on Windows is caused by two regressions introduced over the past decade but not caught because this is a manual test, not an automated test... I'm going to see if I can't get this test passing on both Linux and Windows. Keep an eye out for additional commits to this PR.

@gredler Checked on windows with the latest fix. The portrait looks good but looks like the fix causes more issues in landscape mode. I require some time to go through the source code changes. Looks like you might be in the process of adding few more changes for Windows issue. Let me know once the PR is ready.

**Portrait**

<img width="1393" alt="Win_PortraitPg#8" src="https://github.com/user-attachments/assets/a6b48dfe-19f0-4739-825f-e50b0ae50128">

**Landscape**

<img width="1532" alt="Win_LandscapePg#8" src="https://github.com/user-attachments/assets/eeeb309f-fd36-4b8f-a77b-d53acc8a178b">

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21980#issuecomment-2484537121


More information about the client-libs-dev mailing list