RFR: JDK-8344057 : Remove doPrivileged calls from unix platform sources in the java.desktop module
Phil Race
prr at openjdk.org
Tue Nov 19 17:32:58 UTC 2024
On Tue, 19 Nov 2024 00:59:36 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> src/java.desktop/unix/classes/sun/print/UnixPrintJob.java line 529:
>>
>>> 527: PrinterOpener po = new PrinterOpener();
>>> 528: @SuppressWarnings("removal")
>>> 529: var dummy = java.security.AccessController.doPrivileged(po);
>>
>> You are no longer running the action
>
> I'm not sure if I understood it correctly: Did you mean remove `implements java.security.PrivilegedAction<Object>` from PrinterOpener class ?
Well, that too. But the main point is WHERE is the code now that calls PrinterOpener.run() ?
The thing that does the actual work. So far as I can see you've deleted the call and done nothing to replace it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22218#discussion_r1848779561
More information about the client-libs-dev
mailing list