RFR: JDK-8344057 : Remove doPrivileged calls from unix platform sources in the java.desktop module

Phil Race prr at openjdk.org
Tue Nov 19 17:41:03 UTC 2024


On Tue, 19 Nov 2024 17:29:53 GMT, Phil Race <prr at openjdk.org> wrote:

>> I'm not sure if I understood it correctly: Did you mean remove `implements java.security.PrivilegedAction<Object>` from PrinterOpener class ?
>
> Well, that too. But the main point is WHERE is the code now that calls PrinterOpener.run() ?
> The thing that does the actual work. So far as I can see you've deleted the call and done nothing to replace it.

So 2 things to do that I can see.
1) after line 526 call po.run();
2) Go to the definition of PrinterOpener and remove implements java.security.PrivilegedAction<Object>

Anything more would be too much refactoring.

Same idea below for PrinterSpooler.

How were you testing this ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22218#discussion_r1848790452


More information about the client-libs-dev mailing list