RFR: 8344064: Remove doPrivileged calls from print/imageio/media classes in the java.desktop module [v2]

Andrey Turbanov aturbanov at openjdk.org
Tue Nov 19 17:51:00 UTC 2024


On Tue, 19 Nov 2024 17:37:16 GMT, Phil Race <prr at openjdk.org> wrote:

>> Remove doPrivileged calls from javax.imageio, javax.print and some sound impl classes
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8344064

src/java.desktop/share/classes/com/sun/media/sound/SoftSynthesizer.java line 635:

> 633:     }
> 634: 
> 635:    static interface RunnableAction<T> {

Can we use `java.util.function.Supplier`  instead?

src/java.desktop/share/classes/com/sun/media/sound/SoftSynthesizer.java line 801:

> 799:                             }
> 800:                             return null;
> 801:                         }).run();

Let's unwrap this `RunnableAction` and put code directly in the `getDefaultSoundbank`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22186#discussion_r1848798744
PR Review Comment: https://git.openjdk.org/jdk/pull/22186#discussion_r1848800902


More information about the client-libs-dev mailing list