RFR: 8344064: Remove doPrivileged calls from print/imageio/media classes in the java.desktop module [v2]

Andrey Turbanov aturbanov at openjdk.org
Tue Nov 19 18:49:59 UTC 2024


On Tue, 19 Nov 2024 18:26:10 GMT, Phil Race <prr at openjdk.org> wrote:

>> src/java.desktop/share/classes/com/sun/media/sound/SoftSynthesizer.java line 801:
>> 
>>> 799:                             }
>>> 800:                             return null;
>>> 801:                         }).run();
>> 
>> Let's unwrap this `RunnableAction` and put code directly in the `getDefaultSoundbank`
>
> No. Refactoring is explicitly a non-goal in these PRs. And minimising required refactoring is a goal.

Will you file a separate ticket to cleanup this?
Current code looks confusing. Creating lambda just to execute it doesn't make much sense.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22186#discussion_r1848874932


More information about the client-libs-dev mailing list