RFR: JDK-8340555 : Open source DnD tests - Set4 [v6]

Harshitha Onkar honkar at openjdk.org
Wed Oct 2 17:29:38 UTC 2024


On Wed, 2 Oct 2024 15:06:24 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment fixes
>
> test/jdk/java/awt/dnd/DragSourceMotionListenerTest.java line 73:
> 
>> 71:     private static final Panel source = new TestPanel();
>> 72:     private static final Panel target = new TestPanel();
>> 73:     private static final DragSource ds = DragSource.getDefaultDragSource();
> 
> Both `source` and `target` are created on the main thread when the `DragSourceMotionListenerTest` class is initialised, before the `main` method is called.
> 
> Is it intended?

Yes, probably to configure the dropTarget.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1784941851


More information about the client-libs-dev mailing list