RFR: JDK-8340555 : Open source DnD tests - Set4 [v6]

[Harshitha Onkar]

On Wed, 2 Oct 2024 15:54:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment fixes
>
> test/jdk/java/awt/dnd/DragToAnotherScreenTest.java line 144:
> 
>> 142:                                                       "getTransferData() Failed",
>> 143:                                                       "Test Failed", JOptionPane.ERROR_MESSAGE);
>> 144:                         PassFailJFrame.forceFail();
> 
> Provide the reason:
> Suggestion:
> 
>                         PassFailJFrame.forceFail("getTransferData() Failed");

Updated

> test/jdk/java/awt/dnd/RejectDragTest.java line 146:
> 
>> 144:             endPoint = new Point(startPoint);
>> 145:             startPoint.translate(50, 50);
>> 146:             endPoint.translate(150, 150);
> 
> Let's make it correct, so that the object fields aren't modified after assigning the reference to the volatile field:
> Suggestion:
> 
>             Point start = frame.getLocationOnScreen();
>             start.translate(50, 50);
>             startPoint = start;
>             
>             Point end = new Point(start);
>             end.translate(150, 150);
>             endPoint = end;

Updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1784958691
PR Review Comment: https://git.openjdk.org/jdk/pull/21213#discussion_r1784958968