RFR: 8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos [v2]

Phil Race prr at openjdk.org
Wed Oct 2 21:41:35 UTC 2024


On Wed, 2 Oct 2024 08:31:13 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos.
>> This could be because of a synchronisation issue in the test.
>> 
>> Fix: I have refactored the test to have a CountDownLatch to monitor the ProgressMonitor and when it reaches 20%, it will be triggered. I have also removed the ProgressMonitor update logic execution from EDT as it would block the EDT sometimes. Also added a proper frame disposal mechanism.
>> 
>> Testing:
>> This is properly tested multiple times in all available platforms in mach5.
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments fixed : Formatting changes

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21293#pullrequestreview-2344148935


More information about the client-libs-dev mailing list